Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ref] [export] [test] Improve csv test to test final output rather than the csv #14779

Merged
merged 1 commit into from
Jul 10, 2019
Merged

[ref] [export] [test] Improve csv test to test final output rather than the csv #14779

merged 1 commit into from
Jul 10, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Clean up a test to test the output of the csv not the internal workings

Before

Test checks the temp table

After

Test checks the actual output. Uses updated function

Technical Details

Now we can capture the csv output in tests....

Comments

@civibot
Copy link

civibot bot commented Jul 10, 2019

(Standard links)

@civibot civibot bot added the master label Jul 10, 2019
@eileenmcnaughton eileenmcnaughton changed the title [ref] [esport] [test] Improve csv test to test final output rather than the csv [ref] [export] [test] Improve csv test to test final output rather than the csv Jul 10, 2019
@mattwire mattwire merged commit 08fc65c into civicrm:master Jul 10, 2019
@eileenmcnaughton eileenmcnaughton deleted the export_test2 branch July 10, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @mattwire